Thread (171 messages) read the whole thread 171 messages, 14 authors, 2017-03-29

Re: [PATCH v2 11/15] net/avp: packet receive functions

From: Bruce Richardson <hidden>
Date: 2017-02-28 10:27:16

On Mon, Feb 27, 2017 at 05:06:24PM +0000, Legacy, Allain wrote:
quoted
-----Original Message-----
From: Stephen Hemminger [mailto:stephen@networkplumber.org]
On Sun, 26 Feb 2017 14:08:59 -0500
Allain Legacy [off-list ref] wrote:

Try not to break error messages onto two lines, it makes it harder when a
user is trying to find the location of the error message with search tools
That's our normal practice, but checkpatches.sh flagged them as warnings.   If these are acceptable exceptions to the tool then are there plans to publish an exhaustive list of checkpatches.sh errors/warnings/checks that can be ignored?  Alternatively, are there plans to change the tools to ignore these automatically and not flag them as issues.   As a contributor it is difficult to tell what will be deemed acceptable and what will not (in some cases) so the default position is to fix all issues before submission. 
In my experience, checkpatch ignores long lines that are due to error
messages. Perhaps you need to put the error message on a separate line,
if other things before the message are of significant size.

/Bruce
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help