Re: [PATCH v4 02/26] eal: return error instead of panic for cpu init

Bruce Richardson [off-list ref] writes:

On Sat, Feb 25, 2017 at 11:02:45AM -0500, Aaron Conole wrote:

quoted

There may be no way to gracefully recover, but the application
should be notified that a failure happened, rather than completely
aborting.  This allows the user to proceed with a "slow-path" type
solution.

Signed-off-by: Aaron Conole <aconole@redhat.com>
---
 lib/librte_eal/linuxapp/eal/eal.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal.c

b/lib/librte_eal/linuxapp/eal/eal.c
index bf6b818..5023d0d 100644

--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c

@@ -740,6 +740,12 @@ static int rte_eal_vfio_setup(void)
 }
 #endif
 
+static void rte_eal_init_alert(const char *msg)
+{
+    fprintf(stderr, "EAL: FATAL: %s\n", msg);
+    RTE_LOG(ERR, EAL, "%s\n", msg);
+}

Checkpatch flags the use of spaces rather than tabs here.

Yes, I caught it too late.  Sorry, I'll fix it.

/Bruce