Re: [PATCH v3 25/25] rte_eal_init: add info about rte_errno codes
From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2017-02-09 22:37:03
On Thu, 9 Feb 2017 09:29:53 -0500 Aaron Conole [off-list ref] wrote:
+ * The error codes returned via rte_errno: + * EACCES indicates a permissions issue. + * + * EAGAIN indicates either a bus or system resource was not available, + * try again. + * + * EALREADY indicates that the rte_eal_init function has already been + * called, and cannot be called again. + * + * EFAULT indicates the tailq configuration name was not found in + * memory configuration. + * + * EINVAL indicates invalid parameters were passed as argv/argc. + * + * EIO indicates failure to setup the logging handlers. This is usually + * caused by an out-of-memory condition. + * + * ENODEV indicates memory setup issues. + * + * ENOTSUP indicates that the EAL cannot initialize on this system. + * + * EUNATCH indicates that the PCI bus is either not present, or is not + * readable by the eal. */
You might want to be less restrictive about wording in the comment. In future more errors might be returned, and also for out of memory ENOMEM is better.