On Thu, Feb 02, 2017 at 11:20:09AM +0000, Nipun Gupta wrote:

quoted

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jerin Jacob
Sent: Wednesday, December 21, 2016 14:55
To: dev@dpdk.org
Cc: thomas.monjalon@6wind.com; bruce.richardson@intel.com; Hemant
Agrawal [off-list ref]; gage.eads@intel.com;
harry.van.haaren@intel.com; Jerin Jacob [off-list ref]
Subject: [dpdk-dev] [PATCH v4 4/6] eventdev: implement PMD registration
functions

This patch adds infrastructure for registering the vdev or
the PCI based event device.

Signed-off-by: Jerin Jacob <redacted>
Acked-by: Bruce Richardson <redacted>
---
 lib/librte_eventdev/rte_eventdev.c           | 236
+++++++++++++++++++++++++++
 lib/librte_eventdev/rte_eventdev_pmd.h       | 111 +++++++++++++
 lib/librte_eventdev/rte_eventdev_version.map |   6 +
 3 files changed, 353 insertions(+)

<snip>

quoted

+
+struct rte_eventdev *
+rte_event_pmd_vdev_init(const char *name, size_t dev_private_size,
+		int socket_id)

Isn't there any requirement to have a clean-up function corresponding to
rte_event_pmd_vdev_init?

I can add one for completeness. I will send a patch on this.

quoted

+{
+	struct rte_eventdev *eventdev;
+
+	/* Allocate device structure */
+	eventdev = rte_event_pmd_allocate(name, socket_id);
+	if (eventdev == NULL)
+		return NULL;
+

<snip>

Regards,
Nipun