On 1/9/2017 7:25 PM, De Lara Guarch, Pablo wrote:

quoted

-----Original Message-----
From: Akhil Goyal [mailto:akhil.goyal@nxp.com]
Sent: Thursday, December 22, 2016 8:17 PM
To: dev@dpdk.org
Cc: thomas.monjalon@6wind.com; Doherty, Declan; De Lara Guarch, Pablo;
hemant.agrawal@nxp.com; Mcnamara, John; nhorman@tuxdriver.com;
Akhil Goyal; Horia Geanta Neag
Subject: [PATCH v2 02/11] crypto/dpaa2_sec: Run time assembler for
Descriptor formation

A set of header files(hw) which helps in making the descriptors
that are understood by NXP's SEC hardware.
This patch provides header files for command words which can be used
for descriptor formation.

Signed-off-by: Horia Geanta Neag <horia.geanta@nxp.com>
Acked-by: Akhil Goyal <redacted>
---

...

quoted

diff --git a/drivers/crypto/dpaa2_sec/hw/rta.h

b/drivers/crypto/dpaa2_sec/hw/rta.h
new file mode 100644
index 0000000..7eb0455

--- /dev/null
+++ b/drivers/crypto/dpaa2_sec/hw/rta.h

...

quoted

+extern enum rta_sec_era rta_sec_era;
+
+/**
+ * rta_set_sec_era - Set SEC Era HW block revision for which the RTA
library
+ *                   will generate the descriptors.
+ * @era: SEC Era (enum rta_sec_era)
+ *
+ * Return: 0 if the ERA was set successfully, -1 otherwise (int)
+ *
+ * Warning 1: Must be called *only once*, *before* using any other RTA
API
+ * routine.
+ *
+ * Warning 2: *Not thread safe*.
+ */

quoted

+static inline int rta_set_sec_era(enum rta_sec_era era)
+{

"static inline int" should go in a different line than the function name and parameters.
So it should be:

static inline int
rta_set_sec_era(enum rta_sec_era era)
{

Could you make this change here and in the rest of the functions?

Thanks,
Pablo

Ok, I will correct in the next version.

Thanks,
Akhil