Re: [PATCH 6/8] crypto/dpaa2_sec: add sec procssing functionality
From: De Lara Guarch, Pablo <hidden>
Date: 2016-12-21 12:39:51
-----Original Message----- From: Akhil Goyal [mailto:akhil.goyal@nxp.com] Sent: Monday, December 05, 2016 12:56 PM To: dev@dpdk.org Cc: thomas.monjalon@6wind.com; eclan.doherty@intel.com; De Lara Guarch, Pablo; hemant.agrawal@nxp.com; Akhil Goyal Subject: [PATCH 6/8] crypto/dpaa2_sec: add sec procssing functionality Signed-off-by: Akhil Goyal <redacted> Reviewed-by: Hemant Agrawal <redacted> --- config/defconfig_arm64-dpaa2-linuxapp-gcc | 6 + drivers/crypto/dpaa2_sec/Makefile | 1 - drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 1337 +++++++++++++++++++++++++++ drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 516 +++++++++++ drivers/net/dpaa2/base/dpaa2_hw_pvt.h | 25 +
For the whole patch, there are some checkpatch errors that you should fix for the v2: http://dpdk.org/ml/archives/test-report/2016-December/005244.html Make sure that you fix also the other patches. Also, a comment below about the capabilities structure. Thanks, Pablo
quoted hunk ↗ jump to hunk
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.hb/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h new file mode 100644 index 0000000..01fae77--- /dev/null +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h@@ -0,0 +1,516 @@
... As far as I could see, this PMD supports AES-CBC, 3DES-CBC and SHA1 and SHA2 with HMAC algorithms, but you are including here more algorithms that this PMD looks like does not support (such as AES XCBC, GCM, etc...)
+ { /* AES XCBC MAC */
+ .op = RTE_CRYPTO_OP_TYPE_SYMMETRIC,
+ {.sym = {
+ .xform_type = RTE_CRYPTO_SYM_XFORM_AUTH,
+ {.auth = {
+ .algo =
RTE_CRYPTO_AUTH_AES_XCBC_MAC,
+ .block_size = 16,
+ .key_size = {
+ .min = 16,
+ .max = 16,
+ .increment = 0
+ },
+ .digest_size = {
+ .min = 16,
+ .max = 16,
+ .increment = 0
+ },
+ .aad_size = { 0 }
+ }, }
+ }, }
+ },