Thread (9 messages) flat view 9 messages, 3 authors, 2016-11-07

Re: [PATCH 3/3] vhost: update comments

From: Mcnamara, John <hidden>
Date: 2016-11-04 13:28:49

-----Original Message-----
From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
Sent: Wednesday, November 2, 2016 3:15 AM
To: dev@dpdk.org
Cc: Mcnamara, John <redacted>; Yuanhan Liu
[off-list ref]
Subject: [PATCH 3/3] vhost: update comments

vhost-cuse is removed, update corresponding comments that are still
referencing it.

Signed-off-by: Yuanhan Liu <redacted>

...

 /*
- * Backend-specific cleanup. Defined by vhost-cuse and vhost-user.
+ * Backend-specific cleanup.
+ *
+ * TODO: fix it; we have one backend now
  */
 void vhost_backend_cleanup(struct virtio_net *dev);
In general it is not a good idea to leave TODOs/Fixmes around unless they
that a better explanation of why they are there.

Apart from that:


Acked-by: John McNamara <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help