Re: [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator
From: Thomas Monjalon <hidden>
Date: 2016-07-15 22:09:26
2016-07-13 16:55, Declan Doherty:
On 05/25/2016 02:34 PM, Piotr Azarewicz wrote:quoted
This patch improve generate_random_key() function by replacing rand() function with reading from /dev/urandom. CID 120136 : Calling risky function (DC.WEAK_CRYPTO) dont_call: rand should not be used for security related applications, as linear congruential algorithms are too easy to break Coverity issue: 120136 Signed-off-by: Piotr Azarewicz <redacted>Acked-by: Declan Doherty <redacted>
Applied, thanks