Re: [PATCH v1 1/1] examples/l2fwd-crypto: improve random key generator
From: Thomas Monjalon <hidden>
Date: 2016-07-11 14:17:25
From: Thomas Monjalon <hidden>
Date: 2016-07-11 14:17:25
2016-06-08 07:46, Azarewicz, PiotrX T:
quoted
2016-05-25 15:34, Piotr Azarewicz:quoted
This patch improve generate_random_key() function by replacing rand() function with reading from /dev/urandom. CID 120136 : Calling risky function (DC.WEAK_CRYPTO) dont_call: rand should not be used for security related applications, as linear congruential algorithms are too easy to break Coverity issue: 120136 Signed-off-by: Piotr Azarewicz <redacted>Is it relevant for this example?Maybe not. But it don't break anything, and in the end make Coverity tool happy. Declan, please share your opinion.
Declan?