Re: [PATCH] crypto: normalize cryptodev pmd names with macros
From: Thomas Monjalon <hidden>
Date: 2016-07-08 10:03:14
From: Thomas Monjalon <hidden>
Date: 2016-07-08 10:03:14
2016-07-07 11:37, Neil Horman:
-PMD_REGISTER_DRIVER(cryptodev_aesni_mb_pmd_drvi, aesni_mb); -DRIVER_REGISTER_PARAM_STRING(aesni_gcm, "max_nb_queue_pairs=<int> " +PMD_REGISTER_DRIVER(cryptodev_aesni_mb_pmd_drv, CRYPTODEV_NAME_AESNI_MB_PMD); +DRIVER_REGISTER_PARAM_STRING(CRYPTODEV_NAME_AESNI_MB_PMD, "max_nb_queue_pairs=<int> " "max_nb_sessions=<int> socket_id=<int>");
A coding style opinion: The line DRIVER_REGISTER_PARAM_STRING is a bit long and I think it would be nice to have only one param per line with an indent like this: DRIVER_REGISTER_PARAM_STRING(CRYPTODEV_NAME_AESNI_MB_PMD, "max_nb_queue_pairs=<int> " "max_nb_sessions=<int> " "socket_id=<int>");