Thread (8 messages) 8 messages, 2 authors, 2016-07-05

Re: [PATCH 1/4] net/virtio-user: fix return value not checked

From: Yuanhan Liu <hidden>
Date: 2016-07-05 11:29:56

On Tue, Jul 05, 2016 at 10:14:28AM +0000, Tan, Jianfeng wrote:
quoted
On Wed, Jun 29, 2016 at 09:05:33AM +0000, Jianfeng Tan wrote:
quoted
-	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1)
-		rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
-				   &get_integer_arg, &cq);
+	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1) {
+		ret = rte_kvargs_process(kvlist,
VIRTIO_USER_ARG_CQ_NUM,
quoted
+					 &get_integer_arg, &cq);
+		if (ret < 0) {
+			PMD_INIT_LOG(ERR, "error to parse %s",
+				     VIRTIO_USER_ARG_CQ_NUM);
+			goto end;
+		}
+	}
 	else if (queues > 1)
Above 2 lines should be in one line. Fixed, and series applied to
dpdk-next-virtio.
Thanks.

But there's another problem in the commit log: the Coverity defect ID should be "127477, 127478"  instead of "127344, 127478". Can you please help make it right?
Done.

	--yliu
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help