Re: [PATCH 1/4] net/virtio-user: fix return value not checked
From: Yuanhan Liu <hidden>
Date: 2016-07-01 02:15:13
From: Yuanhan Liu <hidden>
Date: 2016-07-01 02:15:13
On Wed, Jun 29, 2016 at 09:05:33AM +0000, Jianfeng Tan wrote:
- if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1)
- rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
- &get_integer_arg, &cq);
+ if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1) {
+ ret = rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
+ &get_integer_arg, &cq);
+ if (ret < 0) {
+ PMD_INIT_LOG(ERR, "error to parse %s",
+ VIRTIO_USER_ARG_CQ_NUM);
+ goto end;
+ }
+ }
else if (queues > 1)Above 2 lines should be in one line. Fixed, and series applied to dpdk-next-virtio. Thanks. --yliu