Re: [PATCH v2 1/3] virtio: conditional compilation cleanup
From: Yuanhan Liu <hidden>
Date: 2016-07-04 12:56:08
From: Yuanhan Liu <hidden>
Date: 2016-07-04 12:56:08
On Mon, Jul 04, 2016 at 06:20:42PM +0530, Jerin Jacob wrote:
quoted
quoted
The former case will have issue as "hw" been used in "if" with vtpci_with_feature.Oh, my bad. I overlooked it. Sorry for that!quoted
OR if you meant just floating "struct virtio_hw *hw" without RTE_MACHINE_CPUFLAG_SSSE3 then it comes error on non x86 as unused "hw" variable. If you meant something else then let me know?I then prefer to keep the "#ifdef .. #endif" on top then. It will stop us from offending a minor rule, while you can remove the ugly "#ifdef" block in the next patch. Works to you?OK. As you wish :-)
Thank you! --yliu