Re: [PATCH v3] mbuf: new flag when Vlan is stripped
From: Thomas Monjalon <hidden>
Date: 2016-06-15 15:20:35
2016-06-15 12:33, Ananyev, Konstantin:
From: Olivier Matz [mailto:olivier.matz@6wind.com]quoted
The behavior of PKT_RX_VLAN_PKT was not very well defined, resulting in PMDs not advertising the same flags in similar conditions. Following discussion in [1], introduce 2 new flags PKT_RX_VLAN_STRIPPED and PKT_RX_QINQ_STRIPPED that are better defined: PKT_RX_VLAN_STRIPPED: a vlan has been stripped by the hardware and its tci is saved in mbuf->vlan_tci. This can only happen if vlan stripping is enabled in the RX configuration of the PMD. For now, the old flag PKT_RX_VLAN_PKT is kept but marked as deprecated. It should be removed from applications and PMDs in a future revision.
[...]
quoted
For PKT_RX_QINQ_PKT, it was only supported on i40e, and the behavior was already correct, so we can reuse the same bit value for PKT_RX_QINQ_STRIPPED. [1] http://dpdk.org/ml/archives/dev/2016-April/037837.html, Signed-off-by: Olivier Matz <redacted>Acked-by: Konstantin Ananyev <redacted>
Applied, thanks