On 06/14/2016 11:15 AM, Ananyev, Konstantin wrote:

quoted

quoted

quoted

If we decide to generalize the ixgbe behavior for all PMDs for this
flag, it will break the applications relying on this flag but with
other PMDs. So for the same reason we added a new PKT_RX_VLAN_STRIPPED
we cannot change the behavior of an existing flag.

Ok, then let's make PKT_RX_VLAN_STRIPPED == PKT_RX_VLAN,
and assign new value to the  PKT_RX_VLAN.
Or have PKT_RX_VLAN_STRIPPED == PKT_RX_VLAN and create a new one:
PKT_RX_VLAN_PRESENT or so.
?

I think adding this new flag/packet_type is a new feature,
because only ixgbe was behaving like this, and this was not
documented. To me, marking the old flag as deprecated is
a good compromise to keep the application relying on this
working. If you feel the term "deprecated" is not adapted,
we could reword it to something weaker.

Yes, that would do I think.
Basically my only concern that we will mark it as deprecated,
and then will remove it (as it is deprecated), without providing
anything new to replace it.

quoted

We should try to not stay in that state too long,

Agree.

quoted

and anybody willing to implement this feature would be welcome. For my
part, this is not something I plan to do yet.

Ok, we'll see what we can do for 16.11.
But no hard promises right now either :)

Great, thanks :)
I'll send an update of the patch taking your comments in
account.

Olivier