Re: [PATCH v3 3/4] bonding: take queue spinlock in rx/tx burst functions
From: Bruce Richardson <hidden>
Date: 2016-06-13 09:18:05
From: Bruce Richardson <hidden>
Date: 2016-06-13 09:18:05
On Sun, Jun 12, 2016 at 06:11:28PM +0100, Bernard Iremonger wrote:
Use rte_spinlock_trylock() in the rx/tx burst functions to take the queue spinlock. Signed-off-by: Bernard Iremonger <redacted> Acked-by: Konstantin Ananyev <redacted> ---
Why does this particular PMD need spinlocks when doing RX and TX, while other device types do not? How is adding/removing devices from a bonded device different to other control operations that can be done on physical PMDs? Is this not similar to say bringing down or hotplugging out a physical port just before an RX or TX operation takes place? For all other PMDs we rely on the app to synchronise control and data plane operation - why not here? /Bruce