Re: [PATCH v3 1/3] fm10k: enable FTAG based forwarding
From: Thomas Monjalon <hidden>
Date: 2016-02-24 16:39:19
2016-02-24 15:42, Bruce Richardson:
On Thu, Feb 04, 2016 at 11:38:47AM +0800, Wang Xiao W wrote:quoted
This patch enables reading sglort info into mbuf for RX and inserting an FTAG at the beginning of the packet for TX. The vlan_tci_outer field selected from rte_mbuf structure for sglort is not used in fm10k now. In FTAG based forwarding mode, the switch will forward packets according to glort info in FTAG rather than mac and vlan table. To activate this feature, user needs to turn ``CONFIG_RTE_LIBRTE_FM10K_FTAG_FWD`` to y in common_linuxapp or common_bsdapp. Currently this feature is supported only on PF, because FM10K_PFVTCTL register is read-only for VF. Signed-off-by: Wang Xiao W <redacted>Any comments on this patch? My thoughts: is there a way in which this could be done without adding in a new build time config option?
Bruce, it's simpler to explain that build time options are forbidden to enable such options. Or the terrific kid's approach: one day, the Big Build-Option Eater will come and will eat every undecided features! ;)