Thread (16 messages) 16 messages, 3 authors, 2016-02-10

Re: [PATCH v3 1/2] version: switch to year/month version numbers

From: Thomas Monjalon <hidden>
Date: 2016-02-10 17:21:43

2016-02-10 17:11, Mcnamara, John:
Hi Alejandro,

Please note the above change to the nfp_net.c code due to the name change
in the version macro names.


I was originally going to change it to this:

    #if RTE_VER_YEAR == 2 && RTE_VER_MONTH >= 1
        dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
    #endif

Or better:

    #if RTE_VERSION >= 0x02010000
        dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
    #endif
Or better:
	#if RTE_VERSION >= RTE_VERSION_NUM(2,1,0,0)
However, since the code was added in DPDK 2.2 the version check doesn't seem
necessary, so I removed it. If you need it back in for some reason let me know.
A version check is needed for external applications or external drivers.
It should not exist in the git tree.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help