Re: [PATCH v17 0/5] User-space Ethtool

Thomas,
	Thanks for clarification. Our next step is to create hooks on virtio and vmxnet3 and other ethtool op.

Thanks again for making prompt reply as I am aware it's very late in your time zone.

Larry

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Thursday, July 16, 2015 6:09 PM
To: Wang, Liang-min
Cc: dev@dpdk.org; O'Driscoll, Tim
Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool

2015-07-16 21:55, Wang, Liang-min:

quoted

Thomas,
	Do you want me to create a separate patch just include the

example/l2fwd-ethtool?

Yes

quoted

	Do you also mean besides the identified Makefiles, you see more

rework needs to be done,

quoted

	or I just need to fix Makefile issue? If just Makefile issue, I could try

to make another attempt tomorrow?

After checking the build there is probably more review to do.
Let's take more time to have something clean and maybe more complete in
2.2.
This patchset is your first contribution to DPDK and is already a nice
achievement.
The new API must now be implemented in more drivers to be effective.

quoted

quoted

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
Sent: Thursday, July 16, 2015 5:48 PM
To: Wang, Liang-min
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v17 0/5] User-space Ethtool

2015-07-16 09:25, Liang-Min Larry Wang:

quoted

This implementation is designed to provide a familar interface for

applications that rely on kernel-space driver to support ethtool_op and
net_device_op for device management. The initial implementation

focuses

quoted

quoted

on ops that can be implemented through existing netdev APIs. More ops

will

quoted

quoted

be supported in latter release.

Applied without example which needs more work, thanks