Thread (148 messages) 148 messages, 6 authors, 2015-07-16

Re: [PATCH v9 2/5] ixgbe: add ops to support ethtool ops

flat view

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2015-06-27 01:33:57

On Fri, 26 Jun 2015 21:19:05 -0400
Liang-Min Larry Wang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+	reg_group = reg_set[g_ind++];
+	while (reg_group) {
+		count += ixgbe_regs_group_count(reg_group);
+		reg_group = reg_set[g_ind++];
+	}
I don't care what checkpatch says, this an example of a loop
which reads better as:

        while ((reg_group = reg_set[g_ind++]))
               count += ixgbe_regs_group_count(reg_group);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help