Re: [PATCH 08/12] dt-bindings: net: snps,dwmac: Add compatible for UltraRISC DP1000 SoC
From: sashiko-bot@kernel.org
Date: 2026-08-25 06:16:14
Also in:
linux-devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The new compatible string is added to the `properties` list but not the `select` block, and there is no dedicated schema file provided, meaning standalone nodes will silently bypass schema validation. --
--- Patch [8]: [PATCH 08/12] dt-bindings: net: snps,dwmac: Add compatible for UltraRISC DP1000 SoC ---commit 95065ea02f1035ffe918e5e47353de103a5fb1ff Author: Jia Wang [off-list ref] dt-bindings: net: snps,dwmac: Add compatible for UltraRISC DP1000 SoC This commit adds the SoC-specific compatible string for the UltraRISC DP1000 GMAC controller to the DesignWare MAC binding properties.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml@@ -119,6 +119,7 @@ properties: - starfive,jh7110-dwmac - tesla,fsd-ethqos - thead,th1520-gmac + - ultrarisc,dp1000-gmac
[Severity: Medium] Will standalone nodes using this compatible string bypass schema validation? It appears this string was added to the properties list, but without a corresponding addition to a select block or a dedicated schema file. When a compatible string is added to properties:compatible:contains:enum, the dt-schema tool considers it a valid, documented string globally and suppresses undocumented compatible warnings. However, without a selection mechanism, no schema will select a node using this string without its generic fallbacks. Incomplete or invalid standalone configurations might completely bypass schema validation and fail silently without tooling warnings. Does this compatible need to be added to the select block in snps,dwmac.yaml to ensure standalone configurations are properly validated? -- Sashiko AI review · https://sashiko.dev/#/patchset/20260824-ultrarisc-dts-v1-0-61ab7aebe9e5@ultrarisc.com?part=8