[PATCH] dmaengine: xilinx: xdma: Fix IS_ERR() vs NULL bug in xdma_probe()
From: Harshit Mogalapalli <hidden>
Date: 2024-08-19 19:36:58
Also in:
kernel-janitors, linux-arm-kernel, lkml
Subsystem:
dma generic offload engine subsystem, the rest, xilinx xdma driver · Maintainers:
Vinod Koul, Linus Torvalds, Lizhi Hou, Brian Xu, Raj Kumar Rampelli
devm_regmap_init_mmio() returns error pointers on error, it doesn't
return NULL. Update the error check.
Fixes: 17ce252266c7 ("dmaengine: xilinx: xdma: Add xilinx xdma driver")
Signed-off-by: Harshit Mogalapalli <redacted>
---
This is based on static analysis with smatch, only compile tested.
---
drivers/dma/xilinx/xdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/xilinx/xdma.c b/drivers/dma/xilinx/xdma.c
index 718842fdaf98..44fae351f0a0 100644
--- a/drivers/dma/xilinx/xdma.c
+++ b/drivers/dma/xilinx/xdma.c@@ -1240,7 +1240,8 @@ static int xdma_probe(struct platform_device *pdev) xdev->rmap = devm_regmap_init_mmio(&pdev->dev, reg_base, &xdma_regmap_config); - if (!xdev->rmap) { + if (IS_ERR(xdev->rmap)) { + ret = PTR_ERR(xdev->rmap); xdma_err(xdev, "config regmap failed: %d", ret); goto failed; }
--
2.39.3