Re: [PATCH v2 1/6] mm: introduce vma->vm_flags modifier functions
From: Matthew Wilcox <willy@infradead.org>
Date: 2023-01-25 18:38:57
Also in:
alsa-devel, amd-gfx, bpf, dri-devel, intel-gfx, kexec, kvm, linux-acpi, linux-arch, linux-arm-msm, linux-crypto, linux-ext4, linux-fbdev, linux-fsdevel, linux-media, linux-mediatek, linux-mm, linux-perf-users, linux-rdma, linux-s390, linux-samsung-soc, linux-scsi, linux-staging, linux-tegra, linux-um, linux-usb, linux-xfs, linuxppc-dev, lkml, loongarch, netdev, nvdimm, selinux, sparclinux, target-devel, virtualization, xen-devel
On Wed, Jan 25, 2023 at 12:38:46AM -0800, Suren Baghdasaryan wrote:
+/* Use when VMA is not part of the VMA tree and needs no locking */
+static inline void init_vm_flags(struct vm_area_struct *vma,
+ unsigned long flags)
+{
+ vma->vm_flags = flags;vm_flags are supposed to have type vm_flags_t. That's not been fully realised yet, but perhaps we could avoid making it worse?
pgprot_t vm_page_prot;
- unsigned long vm_flags; /* Flags, see mm.h. */
+
+ /*
+ * Flags, see mm.h.
+ * WARNING! Do not modify directly.
+ * Use {init|reset|set|clear|mod}_vm_flags() functions instead.
+ */
+ unsigned long vm_flags;Including changing this line to vm_flags_t