Re: [RFC 1/1] drivers/dma/*: replace tasklets with workqueue

On 4/26/2022 7:45 PM, Vinod Koul wrote:

On 19-04-22, 21:16, Allen Pais wrote:

quoted

The tasklet is an old API which will be deprecated, workqueue API
cab be used instead of them.

What is the reason for tasklet removal, I am not sure old is a reason to
remove an API...

quoted

This patch replaces the tasklet usage in drivers/dma/* with a
simple work.

Dmaengines need very high throughput, one of the reasons in dmaengine
API design to use tasklet was higher priority given to them. Will the
workqueue allow that...?

Wouldn't the logical move be to convert threaded irq IF tasklets are 
being deprecated rather than using workqueue as replacement?

Also, wouldn't all the spin_lock_bh() calls need to be changed to 
spin_lock_irqsave() now? Probably not as simple as just replace tasklet 
with workqueue.