On Wed, Dec 08 2021 at 11:53, Jason Gunthorpe wrote:

On Mon, Dec 06, 2021 at 11:39:28PM +0100, Thomas Gleixner wrote:

quoted

 static void xen_pv_teardown_msi_irqs(struct pci_dev *dev)
 {
-	struct msi_desc *msidesc = first_pci_msi_entry(dev);
-
-	if (msidesc->pci.msi_attrib.is_msix)
+	if (msi_device_has_property(&dev->dev, MSI_PROP_PCI_MSIX))
 		xen_pci_frontend_disable_msix(dev);
 	else
 		xen_pci_frontend_disable_msi(dev);

Same remark as for power, we have a pci_dev, so can it be
dev->msix_enabled?

Yes, let me rework that.