Re: [PATCH 01/11] ASoC: dai_dma: remove slave_id field
From: Lars-Peter Clausen <lars@metafoo.de>
Date: 2021-11-15 10:14:48
Also in:
alsa-devel, dri-devel, linux-arm-kernel, linux-arm-msm, linux-mmc, linux-serial, linux-spi, linux-staging, linux-tegra, lkml
On 11/15/21 9:53 AM, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de> This field is never set, and serves no purpose, so remove it.
I agree that we should remove it. Its been legacy support code for a while, but the description that there is no user is not right. The tegra20_spdif driver obviously uses it and that user is removed in this patch. I think it makes sense to split that out into a separate patch with a description why the driver will still work even with slave_id removed. Maybe the best is to remove the whole tegra20_spdif driver.
quoted hunk ↗ jump to hunk
diff --git a/sound/soc/tegra/tegra20_spdif.c b/sound/soc/tegra/tegra20_spdif.c index 9fdc82d58db3..1c3385da6f82 100644 --- a/sound/soc/tegra/tegra20_spdif.c +++ b/sound/soc/tegra/tegra20_spdif.c@@ -284,7 +284,6 @@ static int tegra20_spdif_platform_probe(struct platform_device *pdev) spdif->playback_dma_data.addr = mem->start + TEGRA20_SPDIF_DATA_OUT; spdif->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES; spdif->playback_dma_data.maxburst = 4; - spdif->playback_dma_data.slave_id = dmareq->start;
dmareq is now unused and should be removed as well.
pm_runtime_enable(&pdev->dev);