Thread (2 messages) 2 messages, 2 authors, 2021-10-25

Re: [PATCH] dmaengine: milbeaut-hdmac: Prefer kcalloc over open coded arithmetic

From: Vinod Koul <vkoul@kernel.org>
Date: 2021-10-25 06:42:27
Also in: linux-hardening, lkml

On 04-09-21, 16:58, Len Baker wrote:
As noted in the "Deprecated Interfaces, Language Features, Attributes,
and Conventions" documentation [1], size calculations (especially
multiplication) should not be performed in memory allocator (or similar)
function arguments due to the risk of them overflowing. This could lead
to values wrapping around and a smaller allocation being made than the
caller was expecting. Using those allocations could lead to linear
overflows of heap memory and other misbehaviors.

So, use the purpose specific kcalloc() function instead of the argument
size * count in the kzalloc() function.
Applied, thanks

-- 
~Vinod
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help