Re: [PATCH] dmaengine: at_xdmac: use module_platform_driver
From: Vinod Koul <vkoul@kernel.org>
Date: 2021-07-28 06:56:58
Also in:
linux-arm-kernel, lkml
From: Vinod Koul <vkoul@kernel.org>
Date: 2021-07-28 06:56:58
Also in:
linux-arm-kernel, lkml
On 25-06-21, 11:00, Clément Léger wrote:
The driver was previously probed with platform_driver_probe. This does not allow the driver to be probed again later if probe function returns -EPROBE_DEFER. This patch replace the use of platform_driver_probe with module_platform_driver which allows that. Signed-off-by: Clément Léger <clement.leger@bootlin.com> --- drivers/dma/at_xdmac.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 64a52bf4d737..109a4c0895f4 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c@@ -2238,11 +2238,7 @@ static struct platform_driver at_xdmac_driver = { } }; -static int __init at_xdmac_init(void) -{ - return platform_driver_probe(&at_xdmac_driver, at_xdmac_probe); -} -subsys_initcall(at_xdmac_init); +module_platform_driver(at_xdmac_driver);
You are also changing the init call here, there is a reason why dmaengine drivers are subsys_initcall.. have you tested this? -- ~Vinod