Am Dienstag, dem 13.07.2021 um 09:12 +0000 schrieb Robin Gong:

On 12/07/21 17:31 Lucas Stach [off-list ref] wrote: 

quoted

Am Montag, dem 12.07.2021 um 03:48 +0000 schrieb Robin Gong:

quoted

On 09/07/21 17:42 Lucas Stach [off-list ref] wrote:

quoted

Am Mittwoch, dem 07.04.2021 um 23:30 +0800 schrieb Robin Gong:

quoted

ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and
i.mx8m/8mm still need this errata. Please refer to nxp official
errata document from

https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
w.n

xp.com%2F&data=04%7C01%7Cyibin.gong%40nxp.com%7C48156bc93d

quoted

quoted

c84ac26e9d08d942bdc0ac%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%

quoted

quoted

7C1%7C637614205017900475%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4

quoted

quoted

wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&a

quoted

quoted

mp;sdata=keYQubzt1jWrKhaxXr40RL41vzFuIn7x1Sasa3p%2F9Xo%3D&res

quoted

quoted

erved=0 .

quoted

For removing workaround on those chips. Add new i.mx6ul type.

Signed-off-by: Robin Gong <redacted>
Acked-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-imx.c | 47
+++++++++++++++++++++++++++++++++++++++++++----
 1 file changed, 43 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c index

cf235b9..d18ee25 100644

--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c

@@ -59,6 +59,7 @@ enum spi_imx_devtype {
 	IMX35_CSPI,	/* CSPI on all i.mx except above */
 	IMX51_ECSPI,	/* ECSPI on i.mx51 */
 	IMX53_ECSPI,	/* ECSPI on i.mx53 and later */
+	IMX6UL_ECSPI,	/* ERR009165 fix from i.mx6ul */

This patch could be a lot smaller if you didn't introduce a new
devtype. You could just use the IMX51_ECSPI in
imx6ul_ecspi_devtype_data, as all you care about as a relevant
difference is the tx_glitch_fixed property, which isn't tied to the devtype.

I knew tx_glitch_fixed was enough but I still prefer to add new
'IMX6UL_ECSPI' because we can clearly choose the right IP which has
fix the issue while legacy IMX51 if it's not fixed by dts.

Sorry, I don't follow this reasoning. You are not using the new IMX6UL_ECSPI
devtype in any way in this patch, other than a single location, where you just
handle it the same as the IMX51_ECSPI devtype.

Okay, will reuse IMX51_ECSPI as devtype, but will still keep "fsl,imx6ul-ecspi".

That's exactly what I meant: have a "fsl,imx6ul-ecspi" compatible with
it's own imx6ul_ecspi_devtype_data, but reuse the IMX51_ECSPI devtype.

Glad we are on the same page now.

Regards,
Lucas