Re: [PATCH v2] dt-bindings: dma: Document RZ/G2L bindings
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-06-16 11:23:58
Also in:
linux-devicetree, linux-renesas-soc
Hi Biju, On Wed, Jun 16, 2021 at 1:14 PM Biju Das [off-list ref] wrote:
Document RZ/G2L DMAC bindings. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- Note:- This patch has dependency on #include <dt-bindings/clock/r9a07g044-cpg.h> file which will be in next 5.14-rc1 release. v1->v2: * Made interrupt names in defined order * Removed src address and channel configuration from dma-cells. * Changed the compatibele string to "renesas,r9a07g044-dmac".
Thanks for the update!
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml
+ interrupt-names: + items: + - const: ch0 + - const: ch1 + - const: ch2 + - const: ch3 + - const: ch4 + - const: ch5 + - const: ch6 + - const: ch7 + - const: ch8 + - const: ch9 + - const: ch10 + - const: ch11 + - const: ch12 + - const: ch13 + - const: ch14 + - const: ch15 + - const: error
You may want to put the "error" interrupt first, like renesas,rcar-dmac.yaml
does, to make life easier when the next SoC reuses this block, but
with a different number of channels.
With that fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds