Thread (3 messages) flat view 3 messages, 3 authors, 2021-09-14
STALE1836d REVIEWED: 1 (0M)

1 review trailer.

[PATCH] dmaengine: pl330: Typecast with enum to fix the coverity warning

From: Harini Katakam <hidden>
Date: 2021-06-29 10:37:25
Also in: lkml
Subsystem: dma generic offload engine subsystem, the rest · Maintainers: Vinod Koul, Linus Torvalds

From: Shravya Kumbham <redacted>

Typecast the flags and flg variables with (enum dma_ctrl_flags) in
pl330_prep_dma_cyclic, pl330_prep_dma_memcpy and pl330_prep_slave_sg
functions to fix the coverity warning.

Addresses-Coverity: Event mixed_enum_type.
Signed-off-by: Shravya Kumbham <redacted>
Signed-off-by: Harini Katakam <redacted>
Reviewed-by: Radhey Shyam Pandey <redacted>
---
 drivers/dma/pl330.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 110de8a60058..35afbad2e1a7 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2752,7 +2752,7 @@ static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic(
 		return NULL;
 
 	pch->cyclic = true;
-	desc->txd.flags = flags;
+	desc->txd.flags = (enum dma_ctrl_flags)flags;
 
 	return &desc->txd;
 }
@@ -2804,7 +2804,7 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
 
 	desc->bytes_requested = len;
 
-	desc->txd.flags = flags;
+	desc->txd.flags = (enum dma_ctrl_flags)flags;
 
 	return &desc->txd;
 }
@@ -2889,7 +2889,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
 	}
 
 	/* Return the last desc in the chain */
-	desc->txd.flags = flg;
+	desc->txd.flags = (enum dma_ctrl_flags)flg;
 	return &desc->txd;
 }
 
-- 
2.17.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help