Re: [PATCH] dmaengine: idxd: Remove redundant variable cdev_ctx
From: Dave Jiang <dave.jiang@intel.com>
Date: 2021-05-06 15:07:51
Also in:
lkml
On 5/6/2021 4:00 AM, Jiapeng Chong wrote:
Variable cdev_ctx is set to '&ictx[wq->idxd->data->type]' but this value is not used, hence it is a redundant assignment and can be removed. Clean up the following clang-analyzer warning: drivers/dma/idxd/cdev.c:300:2: warning: Value stored to 'cdev_ctx' is never read [clang-analyzer-deadcode.DeadStores]. Reported-by: Abaci Robot <redacted> Signed-off-by: Jiapeng Chong <redacted>
Acked-by: Dave Jiang <dave.jiang@intel.com> Thanks.
quoted hunk ↗ jump to hunk
--- drivers/dma/idxd/cdev.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/dma/idxd/cdev.c b/drivers/dma/idxd/cdev.c index 302cba5..6c72089 100644 --- a/drivers/dma/idxd/cdev.c +++ b/drivers/dma/idxd/cdev.c@@ -295,9 +295,7 @@ int idxd_wq_add_cdev(struct idxd_wq *wq) void idxd_wq_del_cdev(struct idxd_wq *wq) { struct idxd_cdev *idxd_cdev; - struct idxd_cdev_context *cdev_ctx; - cdev_ctx = &ictx[wq->idxd->data->type]; idxd_cdev = wq->idxd_cdev; wq->idxd_cdev = NULL; cdev_device_del(&idxd_cdev->cdev, &idxd_cdev->dev);