Re: [PATCH v4 1/2] dt-bindings: dma: add schema for altr,msgdma
From: Olivier Dautricourt <hidden>
Date: 2021-05-04 13:51:36
Also in:
linux-devicetree, lkml
Hello Rob, The 05/03/2021 17:06, Rob Herring wrote:
On Thu, Apr 29, 2021 at 9:16 AM Olivier Dautricourt [off-list ref] wrote:quoted
- add schema for Altera mSGDMA bindings in devicetree. - add myself as 'Odd fixes' maintainer for this driverWhile I guess valid, the tools (b4) don't like the '/' in your message-id. Lore will escape it fine, but then you have to escape the url. Would be nice to avoid all that, but maybe this is Exchange's doing?
Yes it must be Exchange's doing, i'm not sure if i can configure this but i'll check.. Thanks for noticing.
quoted
Signed-off-by: Olivier Dautricourt <redacted> --- Notes: Changes in v2: - fix reg size in dt example - fix dt_binding check warning - add list in MAINTAINERS entry Changes from v2 to v3: none Changes from v3 to v4: none .../devicetree/bindings/dma/altr,msgdma.yaml | 62 +++++++++++++++++++ MAINTAINERS | 7 +++ 2 files changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/dma/altr,msgdma.yamldiff --git a/Documentation/devicetree/bindings/dma/altr,msgdma.yaml b/Documentation/devicetree/bindings/dma/altr,msgdma.yaml new file mode 100644 index 000000000000..295e46c84bf9 --- /dev/null +++ b/Documentation/devicetree/bindings/dma/altr,msgdma.yaml@@ -0,0 +1,62 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/dma/altr,msgdma.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Altera mSGDMA IP core + +maintainers: + - Olivier Dautricourt <olivier.dautricourt@orolia.com> + +description: | + Altera / Intel modular Scatter-Gather Direct Memory Access (mSGDMA) + intellectual property (IP) + +allOf: + - $ref: "dma-controller.yaml#" + +properties: + compatible: + const: altr,msgdmaNeeds an SoC specific compatible.
It should be compatible with altera's socfpga family.
Should i leave a general compatible field such as "altr,msgdma" ?
example:
compatible:
enum:
- altr,socfpga-msgdma
- altr,msgdma
Thanks,
Olivier