Re: [PATCH v3 14/17] crypto: qce: Print a failure msg in case probe() fails
From: Thara Gopinath <hidden>
Date: 2021-05-21 01:55:19
Also in:
linux-arm-msm, linux-clk, linux-crypto, linux-devicetree, lkml
On 5/19/21 10:36 AM, Bhupesh Sharma wrote:
Print a failure message (dev_err) in case the qcom qce crypto driver probe() fails. Cc: Thara Gopinath <redacted> Cc: Bjorn Andersson <redacted> Cc: Rob Herring <robh+dt@kernel.org> Cc: Andy Gross <agross@kernel.org> Cc: Herbert Xu <herbert@gondor.apana.org.au> Cc: David S. Miller <davem@davemloft.net> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Michael Turquette <redacted> Cc: Vinod Koul <vkoul@kernel.org> Cc: dmaengine@vger.kernel.org Cc: linux-clk@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: bhupesh.linux@gmail.com Signed-off-by: Bhupesh Sharma <redacted>
I kind of felt you can club patch 14 and 15. But it is upto you.. FWIW, Reviewed-by: Thara Gopinath <redacted> Warm Regards Thara
quoted hunk ↗ jump to hunk
--- drivers/crypto/qce/core.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c index 8c3c68ba579e..aecb2cdd79e5 100644 --- a/drivers/crypto/qce/core.c +++ b/drivers/crypto/qce/core.c@@ -300,6 +300,7 @@ static int qce_crypto_probe(struct platform_device *pdev) err_clks_core: clk_disable_unprepare(qce->core); err_out: + dev_err(dev, "%s failed : %d\n", __func__, ret); return ret; }