Re: [V2][PATCH] dmaengine: xilinx: dpdma: initialize registers before request_irq
From: Vinod Koul <vkoul@kernel.org>
Date: 2021-05-10 16:11:06
Also in:
linux-arm-kernel, lkml
From: Vinod Koul <vkoul@kernel.org>
Date: 2021-05-10 16:11:06
Also in:
linux-arm-kernel, lkml
On 30-04-21, 14:40, quanyang.wang@windriver.com wrote:
From: Quanyang Wang <redacted> In some scenarios (kdump), dpdma hardware irqs has been enabled when calling request_irq in probe function, and then the dpdma irq handler xilinx_dpdma_irq_handler is invoked to access xdev->chan[i]. But at this moment xdev->chan[i] hasn't been initialized. We should ensure the dpdma controller to be in a consistent and clean state before further initialization. So add dpdma_hw_init() to do this. Furthermore, in xilinx_dpdma_disable_irq, disable all interrupts instead of error interrupts.
Applied, thanks -- ~Vinod