Thread (2 messages) 2 messages, 2 authors, 2021-01-04

Re: [PATCH] dmaengine: qcom: fix gpi undefined behavior

From: Vinod Koul <vkoul@kernel.org>
Date: 2021-01-04 12:39:49
Also in: linux-arm-msm, lkml

On 03-01-21, 14:57, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@arndb.de>

gcc points out an incorrect error handling loop:

drivers/dma/qcom/gpi.c: In function 'gpi_ch_init':
drivers/dma/qcom/gpi.c:1254:15: error: iteration 2 invokes undefined behavior [-Werror=aggressive-loop-optimizations]
 1254 |  struct gpii *gpii = gchan->gpii;
      |               ^~~~
drivers/dma/qcom/gpi.c:1951:2: note: within this loop
 1951 |  for (i = i - 1; i >= 0; i++) {
      |  ^~~

Change the loop to correctly walk backwards through the
initialized fields rather than off into the woods.
Applied, thanks

-- 
~Vinod
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help