Thread (33 messages) 33 messages, 4 authors, 2020-05-14

RE: [PATCH v7 RESEND 03/13] Revert "dmaengine: imx-sdma: fix context cache"

From: Robin Gong <hidden>
Date: 2020-05-13 08:06:38
Also in: linux-arm-kernel, linux-devicetree, linux-spi, lkml

On 2020/05/13 Fuzzey, Martin [off-list ref] wrote:
On Wed, 13 May 2020 at 08:07, Sascha Hauer [off-list ref]
wrote:
quoted
On Tue, May 12, 2020 at 01:32:26AM +0800, Robin Gong wrote:
quoted
This reverts commit d288bddd8374e0a043ac9dde64a1ae6a09411d74, since
'context_loaded' finally removed.

Signed-off-by: Robin Gong <redacted>
---
I think this can safely be folded into the next patch which makes it
more clear what is happening.
Agreed,
not only that but having 2 separate patches also means that the bug that was
fixed by the commit being reverted could reappear during bisection.

More generally I think reverts should be reserved for commits that later turn
out to be wrong or unneeded (ie should never really have been applied).
If they were OK at the time but later become unnecessary due to other code
changes I think all the related modifications should be done in a single normal
non revert patch.
Okay, will remove it in v8.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help