RE: [RESEND v6 06/13] spi: imx: fix ERR009165

On 2020/03/10 Uwe Kleine-König [off-list ref] wrote:

Hello,

On Tue, Mar 10, 2020 at 08:27:41AM +0000, Robin Gong wrote:

quoted

On 2020/03/10 Sascha Hauer [off-list ref] wrote:

quoted

On Tue, Mar 10, 2020 at 07:31:55PM +0800, Robin Gong wrote:

quoted

 	writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL);

@@ -612,12 +613,14 @@ static int mx51_ecspi_prepare_transfer(struct

spi_imx_data *spi_imx,

 static void mx51_setup_wml(struct spi_imx_data *spi_imx)  {
+	u32 tx_wml = 0;
+
 	/*
 	 * Configure the DMA register: setup the watermark
 	 * and enable DMA request.
 	 */
 	writel(MX51_ECSPI_DMA_RX_WML(spi_imx->wml - 1) |
-		MX51_ECSPI_DMA_TX_WML(spi_imx->wml) |
+		MX51_ECSPI_DMA_TX_WML(tx_wml) |

tx_wml is never assigned any other value than 0. Drop the variable.

That's prepared for 07/13 patch which may assign spi_imx->wml to tx_wml.

Then this belongs into patch 7, right?

Okay, understood your concern. Then I'll drop tx_wml to make it clear.

Best regards
Uwe

--
Pengutronix e.K.                           | Uwe Kleine-König
|
Industrial Linux Solutions                 |
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p
engutronix.de%2F&data=02%7C01%7Cyibin.gong%40nxp.com%7Cca6f14
28f4224fa79f1d08d7c4ce4a41%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0
%7C0%7C637194262606339591&sdata=kI9HAyC%2FG3qmrIrLmfUDJ7dac
%2FOEDBtDm4oeRyak1xE%3D&reserved=0 |