Thread (55 messages) 55 messages, 5 authors, 2019-11-26

Re: [PATCH v4 12/15] dmaengine: ti: New driver for K3 UDMA - split#4: dma_device callbacks 1

From: Peter Ujfalusi <hidden>
Date: 2019-11-11 10:28:56
Also in: linux-arm-kernel, linux-devicetree, lkml


On 11/11/2019 8.09, Vinod Koul wrote:
On 01-11-19, 10:41, Peter Ujfalusi wrote:
quoted
+/* Not much yet */
?
Forgot to remove it when I did implemented the tx_status() ;)
quoted
+static enum dma_status udma_tx_status(struct dma_chan *chan,
+				      dma_cookie_t cookie,
+				      struct dma_tx_state *txstate)
+{
+	struct udma_chan *uc = to_udma_chan(chan);
+	enum dma_status ret;
+	unsigned long flags;
+
+	spin_lock_irqsave(&uc->vc.lock, flags);
+
+	ret = dma_cookie_status(chan, cookie, txstate);
+
+	if (!udma_is_chan_running(uc))
+		ret = DMA_COMPLETE;
so a paused channel will result in dma complete status?
The channel is still enabled (running), the pause only sets a bit in the
channel's real time control register.

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help