Re: [PATCH v2 1/3] dt-bindings: dmaengine: dma-common: Change dma-channel-mask to uint32-array
From: Rob Herring <robh@kernel.org>
Date: 2019-09-18 13:28:38
Also in:
linux-devicetree, lkml
On Tue, Sep 10, 2019 at 02:45:57PM +0300, Peter Ujfalusi wrote:
quoted hunk ↗ jump to hunk
Make the dma-channel-mask to be usable for controllers with more than 32 channels. Signed-off-by: Peter Ujfalusi <redacted> --- Documentation/devicetree/bindings/dma/dma-common.yaml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/dma/dma-common.yaml b/Documentation/devicetree/bindings/dma/dma-common.yaml index ed0a49a6f020..41460946be64 100644 --- a/Documentation/devicetree/bindings/dma/dma-common.yaml +++ b/Documentation/devicetree/bindings/dma/dma-common.yaml@@ -25,11 +25,19 @@ properties: Used to provide DMA controller specific information. dma-channel-mask: - $ref: /schemas/types.yaml#definitions/uint32 description: Bitmask of available DMA channels in ascending order that are not reserved by firmware and are available to the kernel. i.e. first channel corresponds to LSB. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32-array + items: + minItems = 1
'='? Just making up the syntax?
+ maxItems = 255 # Should be enough + - description: Mask of channels 0-31 + - description: Mask of channels 32-63
You are mixing a schema and list here...
+ ...
That's end of doc marker in YAML...
+ - description: Mask of chnanels X-(X+31)
Obviously, this was not validated with 'make dt_binding_check'. What you
want is:
allOf:
- $ref: /schemas/types.yaml#/definitions/uint32-array
- minItems: 1
maxItems: 255 # Should be enough
Rob