[3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer
From: Radhey Shyam Pandey <hidden>
Date: 2018-09-11 09:31:15
Also in:
linux-arm-kernel, lkml
From: Radhey Shyam Pandey <hidden>
Date: 2018-09-11 09:31:15
Also in:
linux-arm-kernel, lkml
quoted
quoted
quoted
Yeah that part was clear but the implementation can be better..I thought over it and it seems having a new interface dma_ctrl_write_64 taking lsb and msb bits input looks better and scalable. It will be similar to existing vdma_desc_write_64 impl. I will send v2 if it looks ok.Yes that is much better, btw why not reuse same routine as common xilinx lib functions :)
Thanks. vdma_desc_write_64 uses a different offset i.e desc_offset. For reusing it we need to have an additional check to derive offset (ctrl_offset/desc_offset) based on channel config type. Considering it, i think a separate helper interface _64 for desc/control offset simplifies the flow. Please let me know your thoughts on it. -Radhey
-- ~Vinod