Re: [PATCH 49/51] buffer, writeback: make __block_write_full_page() honor cgroup writeback
From: Jan Kara <jack@suse.cz>
Date: 2015-07-01 19:21:08
Also in:
linux-fsdevel, linux-mm, lkml
On Fri 22-05-15 17:14:03, Tejun Heo wrote:
[__]block_write_full_page() is used to implement ->writepage in various filesystems. All writeback logic is now updated to handle cgroup writeback and the block cgroup to issue IOs for is encoded in writeback_control and can be retrieved from the inode; however, [__]block_write_full_page() currently ignores the blkcg indicated by inode and issues all bio's without explicit blkcg association. This patch adds submit_bh_blkcg() which associates the bio with the specified blkio cgroup before issuing and uses it in __block_write_full_page() so that the issued bio's are associated with inode_to_wb_blkcg_css(inode).
One comment below...
quoted hunk ↗ jump to hunk
@@ -44,6 +45,9 @@ #include <trace/events/block.h> static int fsync_buffers_list(spinlock_t *lock, struct list_head *list); +static int submit_bh_blkcg(int rw, struct buffer_head *bh, + unsigned long bio_flags,
The argument bio_flags is unused. What is is good for? Honza -- Jan Kara [off-list ref] SUSE Labs, CR