Re: [PATCH 42/51] writeback: make wakeup_dirtytime_writeback() handle multiple bdi_writeback's
From: Jan Kara <jack@suse.cz>
Date: 2015-07-01 08:20:15
Also in:
linux-fsdevel, linux-mm, lkml
On Fri 22-05-15 17:13:56, Tejun Heo wrote:
wakeup_dirtytime_writeback() currently only starts writeback on the root wb (bdi_writeback). For cgroup writeback support, update the function to check all wbs. Signed-off-by: Tejun Heo <tj@kernel.org> Cc: Jens Axboe <axboe@kernel.dk> Cc: Jan Kara <jack@suse.cz> Cc: Theodore Ts'o <tytso@mit.edu>
Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.com> Honza
quoted hunk ↗ jump to hunk
--- fs/fs-writeback.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 508e10c..8ae212e 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c@@ -1260,9 +1260,12 @@ static void wakeup_dirtytime_writeback(struct work_struct *w) rcu_read_lock(); list_for_each_entry_rcu(bdi, &bdi_list, bdi_list) { - if (list_empty(&bdi->wb.b_dirty_time)) - continue; - wb_wakeup(&bdi->wb); + struct bdi_writeback *wb; + struct wb_iter iter; + + bdi_for_each_wb(wb, bdi, &iter, 0) + if (!list_empty(&bdi->wb.b_dirty_time)) + wb_wakeup(&bdi->wb); } rcu_read_unlock(); schedule_delayed_work(&dirtytime_work, dirtytime_expire_interval * HZ);-- 2.4.0
-- Jan Kara [off-list ref] SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>