On Thu, 1 May 2014 08:54:50 -0400 Johannes Weiner [off-list ref] wrote:

On Mon, Apr 28, 2014 at 05:04:26PM +0200, Michal Hocko wrote:

quoted

On Tue 22-04-14 11:59:23, Michal Hocko wrote:

quoted

On Sat 19-04-14 07:01:43, Jianyu Zhan wrote:

quoted

introduce helper mem_cgroup_zoneinfo_zone(). This will make
mem_cgroup_iter() code more compact.

I dunno. Helpers are usually nice but this one adds more code then it
removes. It also doesn't help the generated code.

So I don't see any reason to merge it.

So should we drop it from mmotm?

Yes, please.

quoted

quoted

quoted

Signed-off-by: Jianyu Zhan <redacted>
---
 mm/memcontrol.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

This helper adds no value, but more code and indirection.

Cc'd Andrew - this is about
mm-memcontrolc-introduce-helper-mem_cgroup_zoneinfo_zone.patch
mm-memcontrolc-introduce-helper-mem_cgroup_zoneinfo_zone-checkpatch-fixes.patch

The patch seemed rather nice to me.  mem_cgroup_zoneinfo_zone()
encapsulates a particular concept and gives it a name.  That's better
than splattering the logic into callsites.

The patch makes no change to code size but that's because gcc is silly.
Mark mem_cgroup_zoneinfo_zone() as noinline and the patch shrinks
.text by 40 bytes.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>