On Mon, Apr 28, 2014 at 05:04:26PM +0200, Michal Hocko wrote:

On Tue 22-04-14 11:59:23, Michal Hocko wrote:

quoted

On Sat 19-04-14 07:01:43, Jianyu Zhan wrote:

quoted

introduce helper mem_cgroup_zoneinfo_zone(). This will make
mem_cgroup_iter() code more compact.

I dunno. Helpers are usually nice but this one adds more code then it
removes. It also doesn't help the generated code.

So I don't see any reason to merge it.

So should we drop it from mmotm?

Yes, please.

quoted

quoted

Signed-off-by: Jianyu Zhan <redacted>
---
 mm/memcontrol.c | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

This helper adds no value, but more code and indirection.

Cc'd Andrew - this is about
mm-memcontrolc-introduce-helper-mem_cgroup_zoneinfo_zone.patch
mm-memcontrolc-introduce-helper-mem_cgroup_zoneinfo_zone-checkpatch-fixes.patch

Thanks!