Thread (63 messages) 63 messages, 7 authors, 2012-12-28

Re: [PATCH 4/7] cgroup_freezer: don't stall transition to FROZEN for PF_NOFREEZE or PF_FREEZER_SKIP tasks

From: Oleg Nesterov <hidden>
Date: 2012-10-22 18:33:46
Also in: lkml

On 10/16, Tejun Heo wrote:
cgroup_freezer doesn't transition from FREEZING to FROZEN if the
cgroup contains PF_NOFREEZE tasks or tasks sleeping with
PF_FREEZER_SKIP set.
And thus the patch looks like another bugfix to me.


Just one question, and this question is offtopic again,
Only kernel tasks can be non-freezable (PF_NOFREEZE)
Hmm. We seem to "leak" PF_NOFREEZE if a kernel thread execs?
Perhaps do_execve_common() should do set_freezable() before return.

Or, at least, simply clear this flag along with PF_KTHREAD in
flush_old_exec().

Oleg.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help