Thread (19 messages) 19 messages, 5 authors, 2012-07-09

Re: 3.5-rc3: BUG: Dentry still in use (1) [unmount of cgroup cgroup]

From: Tejun Heo <hidden>
Date: 2012-06-30 07:04:40
Also in: lkml

Hello, Al.

On Fri, Jun 29, 2012 at 11:47 PM, Al Viro [off-list ref] wrote:
On Sat, Jun 30, 2012 at 02:13:02PM +0800, Li Zefan wrote:
quoted
So it's bad to have dentry refcnts dangling after umount.
No shit.  Yes, it is bad.  What on the Earth is cgroup code doing with
those?  And what could it possibly want to do with dentry reference
after the filesystem has been shut down, assuming it could hold one
in the first place?
cgroup interface code was copied from sysfs back when it was
piggybacking internal data structures to dentries, so, unfortunately,
sysfs is still using dentries to manage internal data structures and
propagates internal refs to dentry refs. There seem to be several
places where dentry ref is held w/o active super ref triggering BUG on
umount. Longer term, it should be updated to share sysfs code, I
guess.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help