Thread (19 messages) 19 messages, 5 authors, 2012-07-09

Re: [PATCH] cgroup: cgroup_rm_files() was calling simple_unlink() with the wrong inode

From: Tejun Heo <hidden>
Date: 2012-07-09 17:11:14
Also in: lkml

On Wed, Jul 04, 2012 at 01:40:39PM +0800, Li Zefan wrote:
Tejun Heo wrote:
quoted
quoted
From 6da2689412c78b97716ec524cc30baf7b46508cd Mon Sep 17 00:00:00 2001
From: Tejun Heo <redacted>
Date: Tue, 3 Jul 2012 10:32:26 -0700

While refactoring cgroup file removal path, 05ef1d7c4a "cgroup:
introduce struct cfent" incorrectly changed the @dir argument of
simple_unlink() to the inode of the file being deleted instead of that
of the containing directory.

The effect of this bug is minor - ctime and mtime of the parent
weren't properly updated on file deletion.

Fix it by using @cgrp->dentry->d_inode instead.

Signed-off-by: Tejun Heo <redacted>
Reported-by: Al Viro <redacted>

Acked-By: Li Zefan <redacted>
I think it's now a bit too late for for-3.5-fixes and the effect of
the bug is rather minor.  Applied to cgroup/for-3.6 w/ stable cc'd.

Thanks.

-- 
tejun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help