On Tue, May 15, 2012 at 10:10:34AM +0900, KAMEZAWA Hiroyuki wrote:

(2012/05/15 3:32), Tejun Heo wrote:

quoted

On Mon, May 14, 2012 at 11:15:56AM -0700, Tejun Heo wrote:

quoted

On Fri, May 11, 2012 at 06:45:18PM +0900, KAMEZAWA Hiroyuki wrote:

quoted

-		if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children))
+		if (cgroup_task_count(cgroup)
+			|| !list_empty(&cgroup->children)) {
+			ret = -EBUSY;
 			goto out;

Why break the line?  It doesn't go over 80 col.

Ooh, it does.  Sorry, my bad.  But still, isn't it more usual to leave
the operator in the preceding line and align the start of the second
line with the first?  ie.

		if (cgroup_task_count(cgroup) ||
		    !list_empty(&cgroup->children)) {

How about this ?
==
From: KAMEZAWA Hiroyuki <redacted>
Date: Fri, 27 Apr 2012 13:19:19 +0900
Subject: [PATCH] memcg: fix error code in hugetlb_force_memcg_empty()

Changelog:
 - clean up.
Reviewed-by: Aneesh Kumar K.V <redacted>
Signed-off-by: KAMEZAWA Hiroyuki <redacted>

Heh, it was a nitpick anyway.  Please feel free to add my reviewed-by
for the whole series.

Thank you!

-- 
tejun

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>