On 03/19/2012 07:33 PM, Michal Hocko wrote:

On Mon 19-03-12 14:58:00, Glauber Costa wrote:

quoted

On 03/19/2012 11:59 AM, KAMEZAWA Hiroyuki wrote:

quoted

In order to encode pc->mem_cgroup and pc->flags to be in a word,
access function to pc->mem_cgroup is required.

This patch replaces access to pc->mem_cgroup with
   pc_to_mem_cgroup(pc)          : pc->mem_cgroup
   pc_set_mem_cgroup(pc, memcg)  : pc->mem_cgroup = memcg

Following patch will remove pc->mem_cgroup.

Signed-off-by: KAMEZAWA Hiroyuki<redacted>

Kame,

I can't see a reason not to merge this patch right now, regardless of
the other ones.

I am not so sure about that. The patch doesn't do much on its own and
reference to the "following patch" might be confusing. Does it actually
help to rush it now?

The Changelog can be worked, that's for sure.
But thought as a style change, it does do good IMHO.

Of course this is an argument to get it in as much as it is an argument 
not to...

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>